Set context when reporting summonInline errors #14405
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarter
reviewed
Feb 2, 2022
| def searchImplicit(tpt: Tree) = | ||
| val evTyper = new Typer(ctx.nestingLevel + 1) | ||
| val evCtx = ctx.fresh.setTyper(evTyper) | ||
| val evidence = evTyper.inferImplicitArg(tpt.tpe, tpt.span)(using evCtx) |
Member
There was a problem hiding this comment.
You could wrap the whole block using inContext(evCtx) { ... } to make sure we don't accidentally use the wrong context anywhere.
Contributor
Author
|
I've signed CLA |
smarter
added
the
backport:nominated
Contributor
|
fix #13406 |
Contributor
There was a problem hiding this comment.
@andrzejressel you should squash and rebases the commits and include a short message explaining what the fix is doing.
Otherwise LGTM
andrzejressel
changed the title
Contributor
Author
|
@nicolasstucki Fixed, should be fine now |
nicolasstucki
added a commit
to dotty-staging/dotty
that referenced
this pull request
Feb 21, 2022
Make same fix in another part of the code.
nicolasstucki
pushed a commit
to dotty-staging/dotty
that referenced
this pull request
Feb 21, 2022
nicolasstucki
added
backport:accepted
nicolasstucki
added a commit
to dotty-staging/dotty
that referenced
this pull request
Feb 22, 2022
Make same fix in another part of the code.
anatoliykmetyuk
added a commit
that referenced
this pull request
Feb 25, 2022
nicolasstucki
added
backport:done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set proper context when reporting summonInline errors - and puts everything in inContext block, so this won't happen in the future.